feat:exof support on baklava #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
denviljclarke
commented
Sep 22, 2023
| @@ -111,7 +111,10 @@ export function SwapConfirmCard({ formValues }: Props) { | |||
| return | |||
| } | |||
| const rateBN = new BigNumber(rate) | |||
| if (rateBN.lt(MIN_EXCHANGE_RATE) || rateBN.gt(MAX_EXCHANGE_RATE)) { | |||
| if ( | |||
| ((toTokenId || fromTokenId) !== 'eXOF' && rateBN.lt(MIN_EXCHANGE_RATE)) || | |||
There was a problem hiding this comment.
Temporary fix to allow testing while we decide if we should keep this rate range check
nvtaveras
approved these changes
Sep 22, 2023
bayological
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds eXOF support for baklava to allow testing using the UI.
There's also a fix for error causing the reverse token button to trigger a swap confirm step, by adding 'button' type as it defaults to 'submit'.
Other changes
I've set the rate range check to ignore eXOF swaps until we decide if we need them. (If we do the range can be configured on a per pair basis)
I've also set the form values in a single function call in the reverse button as setting them sequentially caused weird quote fetching behaviour.
Tested
I didn't do all the regression test cases, but I did a good few swaps with different currencies and amounts. I did notice there is still rounding issue sometimes when using max, so I've created a issue to capture this, otherwise the quotes and swaps work as expected.
Related issues
Checklist before requesting a review